fix: preserve original key in _stat_for() option lookup#2
Closed
fix: preserve original key in _stat_for() option lookup#2
Conversation
_check() stored the file argument in $_last_call_for for -X _ caching. When the argument was a filehandle reference (not a string path), this prevented the filehandle from being garbage collected, keeping the underlying file descriptor open. This caused "spooky action-at-a-distance" bugs: e.g. a socketpair read hanging because a dup'd write-end filehandle was kept alive by the leaked reference, even after leaving scope. Fix: only cache string filenames in $_last_call_for, not references. Ref: cpan-authors/Test-MockFile#179 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ef-leak fix: prevent filehandle reference leak in stat override
Add CLAUDE.md with project guidance for Claude Code sessions. Exclude CLAUDE.md and local/ directory from Dist::Zilla GatherDir so they don't end up in the CPAN tarball.
Update actions/checkout and CI
_stat_for() lowercased $k and stripped the st_ prefix in-place, then used the modified $k to index into the original %$opts hash. This silently dropped any option passed with an st_ prefix (e.g. st_size) or mixed case (e.g. SIZE), because the modified key no longer matched the original hash entry. Use a separate $name variable for normalization so the original $k is preserved for the hash lookup. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
need to resubmit to the parent repo |
Owner
|
@Koan-Bot squash |
Collaborator
Author
|
Superseded by a more comprehensive fix in upstream/main that includes both key preservation AND unknown key validation with helpful error messages. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix
_stat_for()so options withst_prefix or mixed case are correctly applied.Why
The loop variable
$kwas modified in-place (lowercased + prefix stripped), then used to index back into the original%$optshash. Options likest_size => 42orSIZE => 42were silently dropped because the modified key didn't match the original hash entry.How
Introduced a separate
$namevariable for normalization, preserving the original$kfor the hash lookup.Testing
Added 4 tests to
t/stat-helpers.tcoveringst_prefix, uppercase, and mixed-case keys. Full suite passes (1076 tests).